Validation results as error metadata #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 29, 2013 11:24
`bouncer.core/validate` now accepts an optional function responsible for
transforming the error metadata map as the first parameter.
Errors returned by
(bouncer.core/validate {:a {:b "1"}}
[:a :b] bouncer.validators/matches #"2" :message "oops")
will contain error metadata in the form of
{:path [:a :b]
:value "1"
:args (#"2")
:metadata {:default-message-format "%s must match ..."
:optional true
:validator :bouncer.validators/matches}
:message "oops"}
instead of an interpolated message. Backwards-compatible behavior can be
achieved by passing `bouncer.core/with-default-messages` as the first
parameter to `validate`.
Any metadata supplied to `defvalidator` will appear in the error
metadata under the `:metadata` key.
|
Just checking, have you had the time to go through the PR? |
|
Hi @dm3 , I'm really sorry about the delay but I've been swamped at work. The PR is on my backlog and I'll get to it soon. I plan to go through it within the next couple of weeks. Thanks for sending it through. |
|
Hi @dm3 , Apologies for having taken so long to get around to this but it's finally done :) The only change I made was default to I'll be releasing this soon as Thank you so much for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #10
validatenow accepts an optional function as the first parameter. This function is responsible for converting error metadata into messages (seecore/with-default-messagesas an example which provides backwards compatible behavior).Error metadata is a map with the following structure:
path- path to the field which produced the errorvalue- value of the field which produced the errorargs- arguments supplied to the validatormetadata- metadata of thedefvalidatorincluding thevalidatorparameter which contains the namespace-prefixed keyword with the name of the validator (e.g. :bouncer.validators/required).message- message supplied to the validator when callingcore/validate