Skip to content

Commit 3dfb815

Browse files
author
lenny
committed
fix: Skip compatibility check when Core Data's version is 0.0.0 (developer build)
closes #532 Signed-off-by: lenny <[email protected]>
1 parent 15f2541 commit 3dfb815

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

internal/bootstrap/handlers/version.go

+10-1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ import (
3434

3535
const (
3636
CorePreReleaseVersion = "master"
37+
CoreDeveloperVersion = "0.0.0"
3738
CoreServiceVersionKey = "version"
3839
VersionMajorIndex = 0
3940
)
@@ -118,7 +119,15 @@ func (vv *VersionValidator) BootstrapHandler(
118119
logger.Info(
119120
"Skipping version compatibility check for Core Pre-release version",
120121
"version",
121-
internal.SDKVersion)
122+
coreVersion)
123+
return true
124+
}
125+
126+
if coreVersion == CoreDeveloperVersion {
127+
logger.Info(
128+
"Skipping version compatibility check for Core Developer version",
129+
"version",
130+
coreVersion)
122131
return true
123132
}
124133

internal/bootstrap/handlers/version_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ func TestValidateVersionMatch(t *testing.T) {
8686
{"SDK Beta Version", "1.0.0", "v0.2.0", false, false},
8787
{"SDK Version malformed", "1.0.0", "", false, true},
8888
{"Core prerelease version", CorePreReleaseVersion, "v1.0.0", false, false},
89+
{"Core developer version", CoreDeveloperVersion, "v1.0.0", false, false},
8990
{"Core version malformed", "12", "v1.0.0", false, true},
9091
{"Core version JSON bad", "", "v1.0.0", false, true},
9192
{"Core version JSON empty", "{}", "v1.0.0", false, true},

0 commit comments

Comments
 (0)