Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new pages and resources may not clear cache (or may pollute it) #29

Open
robotpony opened this issue Jan 10, 2018 · 1 comment
Open

Comments

@robotpony
Copy link
Member

robotpony commented Jan 10, 2018

As LemonSync operates asynchronously, it's possible for local changes to be sync'd before they're ready, or for the changes to pollute/occlude other items in the cache.

Cases:

  • Copying a page template isn't atomic, and may sync in various states
    • Copied template sync'd before header is updated, and header URL occludes another page template's URL (i.e., the same URL due to copying or other mistake). New page makes old page inaccessible until cache is cleared.
    • Page template name and/or filename may occlude files in cache or listing
  • Certain changes that affect template headers or filenames may result in similar issues

Once the files are corrected and synchronized, clearing the site cache fixes all issues observed.

There may be other side-effects in synchronizing partly-done copies. Ideally, LemonSync should not synchronize files in a few cases:

  • where file, key, or folder names collide
  • where headers are incomplete

Additionally, LemonSync should clear the entire cache in these special cases:

  • new file of any sort
  • changes to manifest or options
  • any full sync (e.g., replace upstream)

Metadata changes (manifest and options) may require a special reload beyond clearing the cache.

@JGlass3919
Copy link

I was bit by this... Thanks for the workaround. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants