Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot refresh a second time after the first refresh #431

Closed
simon-paradis-jive opened this issue Apr 19, 2023 · 0 comments · Fixed by #434
Closed

Cannot refresh a second time after the first refresh #431

simon-paradis-jive opened this issue Apr 19, 2023 · 0 comments · Fixed by #434

Comments

@simon-paradis-jive
Copy link

simon-paradis-jive commented Apr 19, 2023

Context

  • node version: v19.7.0
  • module version with issue: 5.0.0
  • last module version without issue: unknown
  • environment (e.g. node, browser, native): node
  • any other relevant information:

What are you trying to achieve or the steps to reproduce?

  • I am using authorization code flow to successfully fetch the first access token 1
  • I can refresh token 1 to get token 2
  • Token 2 cannot be refreshed because it no longer has a refresh_token associated. This is because our OAuth2 /token endpoint will only provide a new refresh token if the original refresh token is still within 60% of is validity period. It doesn't echo back the original refresh token.

This behavior is acceptable per RFC 6749 Section 4.1.4

What was the result you got?

Got a token that cannot be refreshed while the initial refresh token is still valid.

What result did you expect?

Tokens should be refreshable until the current refresh token is no longer valid.

Perhaps the library could consider using the current refresh token if the response does not include one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant