Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC jobs are run before move_files_storage sometimes #31

Closed
glormph opened this issue Jan 18, 2023 · 2 comments · Fixed by #83
Closed

QC jobs are run before move_files_storage sometimes #31

glormph opened this issue Jan 18, 2023 · 2 comments · Fixed by #83
Labels
Milestone

Comments

@glormph
Copy link
Member

glormph commented Jan 18, 2023

Job for move is waiting for dataset (other move job or PDC), QC is singlefile and doesnt wait for dataset ops. QC then does not work bc wrong path. Pls fix:

  • QC runs before move storage
  • Also convert_mzml runs before rename_dset_storage_loc ?
@glormph glormph changed the title QC jobs are run before move_files_storage sometimes (move is waiting for dataset, QC is singlefile and doesnt wait), that does not work QC jobs are run before move_files_storage sometimes Jan 18, 2023
@glormph glormph added the bug label Jan 18, 2023
@glormph
Copy link
Member Author

glormph commented Feb 23, 2023

Can we make QC wait for move job on file -> will wait and still run QCs in parallel

@glormph
Copy link
Member Author

glormph commented Apr 15, 2024

I will fix this by no longer having QCs in dedicated datasets. Instead, they'll be in folders but not associated to a dataset, which doesnt make sense anyway - they are not analysed together and dont represent samples from an identical experiment. Or not really anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant