Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve codegen (typescript) #2072

Open
2 tasks done
kevin-legion opened this issue Jun 16, 2022 · 2 comments
Open
2 tasks done

Improve codegen (typescript) #2072

kevin-legion opened this issue Jun 16, 2022 · 2 comments
Assignees
@kevin-legion
Labels
area: editor area: egui area: online Related to online or distributed functionalities priority: P2 Medium type: enhancement Improvement of existing feature
Milestone
M3

Comments

@kevin-legion
Copy link

kevin-legion commented Jun 16, 2022 •
edited
Loading

  • Instead of splitting the api function argument as query, params, etc... let's stick to the OpenAPI way, that is only 3 arguments: params, headers, and body
  • Convert cases (underscore and dash to camel case)

Regarding the second one, I wonder if we're not going to use the Rust underscore convention in TypeScript as well since it makes the code a bit more consistent for everyone @timnitsas-legion

While at it I'll also drop the last remnants of gRpc
@kevin-legion kevin-legion self-assigned this Jun 16, 2022
@tltran-legion tltran-legion added priority: P2 Medium area: egui type: enhancement Improvement of existing feature area: editor area: online Related to online or distributed functionalities labels Jun 16, 2022
@tltran-legion tltran-legion added this to the M3 milestone Jun 17, 2022
@kevin-legion kevin-legion mentioned this issue Jun 17, 2022
Merged
4 tasks
@kevin-legion
Copy link
Author

Done in #2083

@kevin-legion
Copy link
Author

We can improve the codegen more but the generated code ergonomics is good enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin-legion kevin-legion

Labels
area: editor area: egui area: online Related to online or distributed functionalities priority: P2 Medium type: enhancement Improvement of existing feature
Projects
None yet
Milestone
M3
Development

No branches or pull requests
2 participants
@tltran-legion @kevin-legion