From 4869d41e077e6a26f5419679dbbe55355f9741a8 Mon Sep 17 00:00:00 2001 From: Ian Guinn Date: Fri, 17 Jan 2025 14:09:50 -0500 Subject: [PATCH 1/2] Make sure t0 filter is zero-area --- src/dspeed/processors/kernels.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/dspeed/processors/kernels.py b/src/dspeed/processors/kernels.py index 925aeee..e640c19 100644 --- a/src/dspeed/processors/kernels.py +++ b/src/dspeed/processors/kernels.py @@ -47,8 +47,11 @@ def t0_filter(rise: int, fall: int, kernel: np.array) -> None: if fall < 0: raise DSPFatal("The length of the fall section must be positive") + if len(kernel) != rise + fall: + raise DSPFatal("The length of the output kernel must equal rise+fall") + for i in range(int(rise)): - kernel[i] = 2 * (int(rise) - i) / (rise**2) + kernel[i] = 2 * (int(rise) - i) / (rise*(rise+1)) for i in range(int(rise), len(kernel), 1): kernel[i] = -1 / fall From bd51ea9a9a18f927f5c31b21a92a0973ecb92c9e Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 17 Jan 2025 19:13:06 +0000 Subject: [PATCH 2/2] style: pre-commit fixes --- src/dspeed/processors/kernels.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dspeed/processors/kernels.py b/src/dspeed/processors/kernels.py index e640c19..ed09d71 100644 --- a/src/dspeed/processors/kernels.py +++ b/src/dspeed/processors/kernels.py @@ -51,7 +51,7 @@ def t0_filter(rise: int, fall: int, kernel: np.array) -> None: raise DSPFatal("The length of the output kernel must equal rise+fall") for i in range(int(rise)): - kernel[i] = 2 * (int(rise) - i) / (rise*(rise+1)) + kernel[i] = 2 * (int(rise) - i) / (rise * (rise + 1)) for i in range(int(rise), len(kernel), 1): kernel[i] = -1 / fall