Add fetch flags #10
Merged
Add fetch flags #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Looks good. Could you also add 2 more things:
|
Regarding your second point, I think this is in the area of API versioning which is tricky and requires some more thought. For now I have implemented a temporary solution and come up with a better solution later |
cmd/flags.go
Outdated
| flags.Error = result | ||
| } | ||
| if err := templ.ExecuteTemplate(w, "flags.html", flags); err != nil { | ||
| fmt.Fprintf(w, "Executing versions template: %v", err) |
There was a problem hiding this comment.
Needs to say flags template
| } | ||
|
|
||
| if versions.NodeVersion < 2 { | ||
| fmt.Fprintf(w, "Flags only support version >= 2. Node version: %d", versions.NodeVersion) |
There was a problem hiding this comment.
That's probably good enough for now, we shall test it
|
We can have your temporary solution and add a next improvement idea to what you come up with (I am curious about your idea of how to make it better) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in conjunction with #7417 in Erigon.
This creates
Fetch Flagsbutton andui/flagsinui_handler.goto fetch context flags via/debug/metrics/flagsin Erigon.