Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of material-icons library from code base #4907

Open
rtibbles opened this issue Feb 11, 2025 · 3 comments · May be fixed by #4913
Open

Remove use of material-icons library from code base #4907

rtibbles opened this issue Feb 11, 2025 · 3 comments · May be fixed by #4913
Assignees
Labels
help wanted Open source contributors welcome

Comments

@rtibbles
Copy link
Member

Desired behavior

We should remove all mentions and usage of material-icons and replace with usage of Kolibri Design System icons where possible. Where not possible, we should just remove it (as in the base.html file).

Current behavior

We rely on an extra dependency for icons that has an unclear upgrade path.

@rtibbles rtibbles added the help wanted Open source contributors welcome label Feb 11, 2025
@SukhvirKooner
Copy link

Hi @rtibbles,
I’d like to take on this issue. Could you clarify whether there are any specific guidelines or references for implementing Kolibri Design System icons? Also, are there any high-priority sections where this change should be made first?

Please assign this to me. Thanks!

@rtibbles
Copy link
Member Author

Search for material-icons in the codebase would be the first start to identify places that need to be updated. Once you've identified what icons are being used, you can cross reference with https://design-system.learningequality.org/icons to see what icons we could replace them with.

It's also possible there are references where it is not being used at all, so we might be able to just remove at those points.

@SukhvirKooner
Copy link

Hi @rtibbles ,
I have raised the PR to replace material-icons with Kolibri Design System icons.
Let me know if changes are needed. Looking forward to your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open source contributors welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants