Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a node seems to place an item at the end of the list, not remove it #4680

Closed
marcellamaki opened this issue Aug 26, 2024 · 2 comments
Labels
P0 - critical Priority: Release blocker or regression TODO: needs reproduced

Comments

@marcellamaki
Copy link
Member

Observed behavior

Observed in the Aug 20 bug bash

Expected behavior

The user should see a node removed from the tree when they delete it (even if the removal is managed async).
There should be no error on the console changeTracker.cleanup is not a function

User-facing consequences

Confusing for the user as to whether or not the node has been removed.

Errors and logs

Video

Steps to reproduce the issue

Not clear to @AlexVelezLl how he got into this state, so needs to be reproduced.

Usage Details

Studio unstable

@marcellamaki marcellamaki added P0 - critical Priority: Release blocker or regression TODO: needs reproduced labels Aug 26, 2024
@learningequality learningequality deleted a comment Aug 26, 2024
@learningequality learningequality deleted a comment Aug 26, 2024
@rtibbles
Copy link
Member

Possible this is the same underlying issue that was fixed by this: #4667 - so this may be fixed on unstable now.

@radinamatic
Copy link
Member

Unable to replicate this anymore, so closing but will keep an eye in case that error resurfaces somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression TODO: needs reproduced
Projects
None yet
Development

No branches or pull requests

4 participants
@radinamatic @rtibbles @marcellamaki and others