Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies between a channel's language and the language of its content #3902

Closed
bjester opened this issue Jan 4, 2023 · 5 comments · Fixed by #4666
Closed

Discrepancies between a channel's language and the language of its content #3902

bjester opened this issue Jan 4, 2023 · 5 comments · Fixed by #4666
Assignees
Labels
P0 - critical Priority: Release blocker or regression TODO: needs decisions

Comments

@bjester
Copy link
Member

bjester commented Jan 4, 2023

Observed behavior

In its public details, a cheffed channel shows a 'Primary Language' pulled from the channel itself which differs from its 'Languages' which is aggregated from the channel content

Public channel card Public channel details
channel-card-lang channel-details-lang

Expected behavior

This is manually correctable, but worth considering whether during channel publishing we should validate that the 'Primary Language' is one of the content languages.

Proposal

We could add the ability to update/validate the channel's 'primary' language in the publishing modal, giving only options as defined by content with those languages, and defaulting to the previous selection if content with that language still exists in the channel.

User-facing consequences

  • How is the channel language used in Kolibri?
  • Is making sure the channel's language accurately reflects the content something that's important beyond display on Studio?

Additional information

https://learningequality.slack.com/archives/C0LK8QS9J/p1671559303563319

@rtibbles
Copy link
Member

rtibbles commented Jan 5, 2023

The channel language is used in filtering for import, so this is a fairly important piece of metadata. This feels like a validation failure first in ricecooker and then in the Studio internal API endpoints, where the only language of resources is Magyar, but the overall channel language is set to English.

@bjester
Copy link
Member Author

bjester commented Jan 5, 2023

Yeah, I agree that we should validate this in ricecooker and its API endpoints. Although, @laurenlichtman raised a point about having some general validation on this during publishing, which could handle non-cheffed and private channels too. It does seem meaningful for all users, and would protect against this discrepancy beyond solely for our own purposes.

@bjester bjester added the P0 - critical Priority: Release blocker or regression label Jan 5, 2023
@bjester bjester added this to the Studio: upcoming patches milestone May 31, 2023
@nucleogenesis
Copy link
Member

This was discussed in a meeting today so I went and checked the latest cheffed PhET channels (not yet published but soon to be done).

PhET Interaktiv Simulyatsiyalar.pdf

image

@akolson
Copy link
Member

akolson commented Jun 19, 2024

@bjester @rtibbles would the below be the intended direction to take for this task?
Also, as long as the previously selected language still exists in the content, it should be the one selected, else no selection?

Image

@akolson
Copy link
Member

akolson commented Jul 25, 2024

For context on next steps, see this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression TODO: needs decisions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants