Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard-only navigation - Tab focus outline is not fully encircling the buttons #9464

Closed
pcenov opened this issue May 27, 2022 · 3 comments
Closed

Keyboard-only navigation - Tab focus outline is not fully encircling the buttons #9464

pcenov opened this issue May 27, 2022 · 3 comments
Labels
DEV: frontend P2 - normal Priority: Nice to have TAG: a11y Affecting accessibility TAG: regression Something that previously worked
Milestone
Planned Patch 2: ...

Comments

@pcenov
Copy link
Member

pcenov commented May 27, 2022

Observed behavior

While testing the keyboard navigation and focus outline improvements I noticed that the buttons in the footer don't get fully encircled by the tab focus outline.

Steps to reproduce the issue

  1. Install Kolibri v0.15.3-beta1
  2. Go through some workflows such as importing a channel or completing a lesson/quiz

Screenshots

2022-05-27_18-05-32
2022-05-27_18-06-54
2022-05-27_18-08-32

Usage Details

Windows 10 and Ubuntu 20 - Chrome, Firefox
@pcenov
Copy link
Member Author

pcenov commented May 27, 2022

@radinamatic

@radinamatic radinamatic added P2 - normal Priority: Nice to have TAG: regression Something that previously worked TAG: a11y Affecting accessibility DEV: frontend labels May 27, 2022
@radinamatic
Copy link
Member

@marcellamaki This is a regression, but not necessarily a result of the changes in the most current patch PRs, not sure if the fix is related to the design system or can be dealt in Kolibri.

It's not a blocker not it has high impact, but would be a bonus to see if we could fix it... 😉

@marcellamaki marcellamaki mentioned this issue Jun 2, 2022
Merged
9 tasks
@marcellamaki
Copy link
Member

Closed with #9478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DEV: frontend P2 - normal Priority: Nice to have TAG: a11y Affecting accessibility TAG: regression Something that previously worked
Projects
None yet
Milestone
Planned Patch 2: Content and a11y
Development

No branches or pull requests
3 participants
@radinamatic @marcellamaki @pcenov