Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize theme token updates #545

Closed
1 task
marcellamaki opened this issue Feb 13, 2024 · 0 comments · Fixed by #551
Closed
1 task

Finalize theme token updates #545

marcellamaki opened this issue Feb 13, 2024 · 0 comments · Fixed by #551
Assignees
Labels
P0 - critical Priority: Release blocker or regression

Comments

@marcellamaki
Copy link
Member

Overview

As we move towards applying the new specs to our products, we need to update KDS to ensure the colors and fonts are available within the design system. The token to hex code mapping has been updated, but we will need to ensure that the components and mixin references are updated as well.

To do

  1. Reference marcella's working branch test-themeing-updates
  2. Audit and apply the proper colors referencing the figma spec - focusing in particular on where there are updates to the token mapping for the component for example, where we used to be using primary (the purple) but now we are using a secondary color token for the blues. Most of the interactive form elements are using secondary tokens. (Buttons, input fields, etc.)
  3. It may be easier to cross-reference with Kolibri, and you can use the new updates to run kolibri without using yarn link, using yarn run devserver-with-kds /path/to/kds instead

Acceptance criteria

  • Standard KComponents have been upgraded to the updated theme colors including form elements, loaders,

Out of scope

  • edge cases in Kolibri or in Studio (i.e. any place there the tokens are referenced directly within a component, rather than just using the default KComponent, or where something like a hex code has snuck in)
  • Font updates
  • Other related updates fixes in Kolibri or Studio (logos, icon colors, etc.)
@marcellamaki marcellamaki added the P0 - critical Priority: Release blocker or regression label Feb 13, 2024
@marcellamaki marcellamaki added this to the Theming support milestone Feb 13, 2024
@LianaHarris360 LianaHarris360 linked a pull request Feb 19, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants