From 3742c5c597de54c39e4b80378c42199f510df8f5 Mon Sep 17 00:00:00 2001 From: Michael Gallaspy Date: Thu, 17 Mar 2016 14:58:07 -0700 Subject: [PATCH] Remove unnecessary assertion in test Seems to have been added by a revert-revert, however it seems to be the wrong assertion to make in this case. Causes flakiness if the modal is dismissed *first*. --- kalite/distributed/features/steps/superuser_create.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/kalite/distributed/features/steps/superuser_create.py b/kalite/distributed/features/steps/superuser_create.py index b3ee55786a..bf6698b38e 100644 --- a/kalite/distributed/features/steps/superuser_create.py +++ b/kalite/distributed/features/steps/superuser_create.py @@ -85,12 +85,6 @@ def step_impl(context): @then("the modal will dismiss") def impl(context): - for id_ in (PASSWORD_CONFIRM_ID, PASSWORD_ID, USERNAME_ID): - try: - is_border_red(context, id_) - raise RedBorderException("The border should not be red for the element with id #{0}".format(id_)) - except AssertionError: - pass # The border should _not_ be red, so the above function _should_ raise an exception assert elem_is_invisible_with_wait(context, context.modal_element, wait_time=120), "modal not dismissed!" def fill_field(context, text, field_id):