Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need a process for building and downloading the Windows Installer.. #308

Closed
bcipolli opened this issue Jul 25, 2013 · 24 comments
Closed
Assignees
Milestone

Comments

@bcipolli
Copy link
Contributor

@ruimalheiro We need two things:

  1. We need to manually rebuild the Windows installer with the latest code on Master. It is missing an important hotfix.
  2. We need a way to build this and make it available automatically.

Can you take care of this first issue ASAP, and comment about the difficulty of setting up the second? It doesn't have to be an elegant solution--we just need a solution that works, for now.

@ghost ghost assigned ruimalheiro Jul 25, 2013
@ruimalheiro
Copy link
Contributor

1 - There is an updated version of it in the dropbox. (already linked to the download page)

2 - I'm assuming that the wanted mechanism, is to download the updated master from Github and build the package. Those operations would be automated.

Right now, you can run "make" to build everything for you but... you need to download the updated "master". So i guess that the idea is to automatize this process. And this is supposed to be run in linux.

@bcipolli is this correct?

@bcipolli
Copy link
Contributor Author

  1. Right, thanks!
  2. Since the central server is in linux, it would be great to move things there. Then we could have all downloads from the same place.
    Second-best option si to have an automated build on a windows machine that uploads to the dropbox.
    Lowest option (but better than nothing) is to have a windows machine where anybody from the team could trigger the build manually.

@bcipolli
Copy link
Contributor Author

This needs to be installed ASAP, possibly as soon as 0.10.2 (within 2 weeks).

@jamalex can you help me get wine set up on the new rackspace server--either by setting it up, or providing me a login?

@ghost ghost assigned jamalex Sep 14, 2013
@bcipolli
Copy link
Contributor Author

@jamalex this is a major blocking item. My only suggestion is to install wine on our current central server--which scares me.

Please advise.

@bcipolli
Copy link
Contributor Author

@jamalex any leads on this? Again, the Windows Installer is out of sync and needs our recent hotfix.

@jamalex
Copy link
Member

jamalex commented Oct 30, 2013

Is it currently essential to have a completely automated build, with 0.11 using a zip-based installer-builder? Can @ruimalheiro or someone just build a new one with the release, for this round?

I agree we want one ASAP, though. I've never actually built the installer, so I don't know how easy or difficult this will be. @ruimalheiro, could you add some instructions for how to build the installer to the README, and perhaps test what it would take to run this under Wine? If we have a good way to do that, I'm happy to set it up on the central server.

@bcipolli
Copy link
Contributor Author

It is absolutely essential because we are consistently making updates (releases, hotfixes) to the software without anyone manually building and updating the Windows installer.

The build is extremely simple, if we either have a Windows machine with a scheduler, or if we have a linux machine with wine on it. My suggestion was we install wine on the new rackspace server, and try to get the windows installer to build there, on a cron schedule.

@bcipolli
Copy link
Contributor Author

bcipolli commented Nov 7, 2013

@jamalex any progress / thoughts on this?

@jamalex
Copy link
Member

jamalex commented Nov 7, 2013

I can try getting it working under Wine, but I'm still waiting for @ruimalheiro to describe how to build it at all (on Windows, or anywhere) in the README on that repo, as requested above.

@bcipolli
Copy link
Contributor Author

bcipolli commented Nov 7, 2013

I see, I missed that--I will take care of that. Need to work on the installer stuff for the IDOC today or tomorrow anyway!

@jamalex
Copy link
Member

jamalex commented Nov 7, 2013

You don't have any FLE time scheduled today -- back to your thesis! :P

I'll ping @ruimalheiro to put together those instructions, so we're not having to do archaeology or reverse engineering on it.

@ruimalheiro
Copy link
Contributor

Hi @bcipolli and @jamalex !

To build it, you just have to update the "ka-lite" folder with the newest version and run "make".

@ruimalheiro
Copy link
Contributor

Somehow i'm not receiving github notifications >< ?

@ruimalheiro
Copy link
Contributor

What we can do, probably write a script to get latest content from github and then make the installer. (Assuming it will run from the "amazon" server). Or we can wait for the new one.

Ideas? (For now, I will write instructions in the repo to avoid this situations).

@jamalex
Copy link
Member

jamalex commented Nov 7, 2013

To build it, you just have to update the "ka-lite" folder with the newest version and run "make".

Can you put the instructions for setting up and building this, from a clean Windows installation, into the README?

I tried it on Wine, installing the Inno Setup compiler according to these instructions, but got the following error:

wine "C:\Program Files (x86)\Inno Setup 5\ISCC.exe" installer-source/KaliteSetupScript.iss
Inno Setup 5 Command-Line Compiler
Copyright (C) 1997-2007 Jordan Russell. All rights reserved.
Portions by Martijn Laan
Inno Setup Preprocessor
Copyright (C) 2001-2002 Alex Yackimoff. All rights reserved.

Compiler engine version: Inno Setup 5.2.3 (ISPP 5.2.3.0)

[ISPP] Preprocessing.

Error on line 11 in Z:\home\jamalex\fle\ka-lite-windows\installer-source\KaliteSetupScript.iss: Column 31:
[ISPP] Undeclared identifier: "StringChange".
Compile aborted.

I also tried using the ISCC.exe that is bundled in the repo, but got:

wine inno-compiler/ISCC.exe installer-source/KaliteSetupScript.iss
fixme:process:SetProcessDEPPolicy (1): stub
fixme:process:SetProcessDEPPolicy (1): stub
Inno Setup 5 Command-Line Compiler
Copyright (C) 1997-2012 Jordan Russell. All rights reserved.
Portions Copyright (C) 2000-2012 Martijn Laan
Inno Setup Preprocessor
Copyright (C) 2001-2004 Alex Yackimoff. All rights reserved.

Compiler engine version: Inno Setup 5.5.3 (a)

[ISPP] Preprocessing.
Error on line 7 in Z:\home\jamalex\fle\ka-lite-windows\installer-source\KaliteSetupScript.iss: [ISPP] Access violation at address 01803190 in module 'ISPP.dll'. Read of address 00000004.
Compile aborted.

Any ideas?

@bcipolli
Copy link
Contributor Author

bcipolli commented Nov 7, 2013

Looks like the Inno executable needed is v5.5.3, but the DLLs don't match. What you installed (via the blog) is v5.2.3; perhaps the slight version differences include different features (including the "StringChange" functionality).

5.5.3 installer also seems to be available; I might suggest trying to install that (after uninstalling the 5.2.3 version, if possible)
http://files.jrsoftware.org/ispack/ispack-5.5.3.exe

@jamalex
Copy link
Member

jamalex commented Nov 7, 2013

Looks like that was the problem with the first traceback I showed, but the second traceback was due to having neglected to add the --recursive when cloning the repo, so it didn't have the ka-lite directory. When I re-cloned with that included, I was able to compile using the included ISCC.exe (nothing to install).

Deleting the ka-lite dir and re-running caused it to output the "Access violation at address 01803190 in module 'ISPP.dll'. Read of address 00000004." message again. Seems like a strange error in response to a missing folder, but at least we have it working now!

@bcipolli
Copy link
Contributor Author

bcipolli commented Nov 7, 2013

Nice! Any idea how long it takes to build on our most powerful server (say, rackspace)?

Trying to see if we can feasibly build on-the-fly with the Windows installer.

@jamalex
Copy link
Member

jamalex commented Nov 7, 2013

On my office computer (desktop, quite fast), it took 31 seconds. Most of that time was spent compressing the KA Lite codebase, so if we could include it as a pre-compressed zip bundle, I imagine this could be reduced substantially.

I also set it up on the RackSpace playground server (an intermediate system, not the biggest/baddest), and it took 38 seconds.

@ruimalheiro
Copy link
Contributor

Check PR #7 in ka-lite-windows repository!

@bcipolli
Copy link
Contributor Author

Taking this off of the release 0.11 timeline; we can simply not offer the windows installer, for now.

@ruimalheiro
Copy link
Contributor

OK @bcipolli !

@aronasorman
Copy link
Collaborator

Managed to build the installer thanks to @ruimalheiro's instructions in the repo. For now we can build manually as needed, so having an automated installer isn't urgent. Punting to 0.11.2.

@aronasorman aronasorman modified the milestones: KA Lite v.0.11.2, KA Lite v0.11.1 Feb 25, 2014
@bcipolli
Copy link
Contributor Author

moved issue to ansible-playbooks repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants