Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-v0.8 refactoring #54

Closed
18 of 19 tasks
justheuristic opened this issue Jun 30, 2020 · 0 comments
Closed
18 of 19 tasks

pre-v0.8 refactoring #54

justheuristic opened this issue Jun 30, 2020 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@justheuristic
Copy link
Member

justheuristic commented Jun 30, 2020

A list of small issues to be solved in bulk before we bump the version

Clean up utils:

  • Remove Connection after we switch to grpc-based connections ( Asyncio connection handlers + logging #45 )
  • Do we really need this many serializers? (or serializers.py at all)
  • relative vs absolute imports: discuss
  • SharedFuture:
    • decided to update and keep it
    • rename to MPFuture?
  • utils.data - maybe rename or merge into utils/__init__.py?
  • Check if concurrent autograd is still necessary in pytorch 1.5 (maybe bump version)
    • no, but we only need it for _RemoteModuleCall.backward
      • Lets implement custom code in moe.py and ditch autograd.py!
  • (delayed) remove find_open_port in favor of builtin port picker or reserve_port (reason: find_open_port fails ~1-3% of the time)

Discussion: gRPC proto files

  • switch from compile_grpc function to pre-compiling in setup.py? (if so: add to pb2 files to .gitignore)
  • use a dedicated folder to store .proto files

Etc:

  • maybe merge hivemind.runtime back into hivemind.server?
  • move all "Thanks to X" notes to acknowledgements section in the readme
  • update PyPI package (0.8.0)
  • create a test case for python -m test_utils.run_server (rationale: we broke it on more than one occasion)
  • msgpackserializer - use strict type checking
  • allow setting max_send/receive_message_length when creating a server
  • conn_handler_processes => num_connection_handlers to avoid confusion?
  • which branches do we still need?
@justheuristic justheuristic mentioned this issue Jun 30, 2020
8 tasks
@justheuristic justheuristic added the help wanted Extra attention is needed label Jun 30, 2020
@justheuristic justheuristic changed the title Clean up utils v0.8 refactoring Jun 30, 2020
@justheuristic justheuristic changed the title v0.8 refactoring pre-v0.8 refactoring Jun 30, 2020
@justheuristic justheuristic linked a pull request Jul 12, 2020 that will close this issue
5 tasks
@justheuristic justheuristic removed a link to a pull request Jul 12, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant