-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Cache): add miniget
command, a minimal version of get
#20568
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0545762
doc(Cache): document two definitions
grunweg 3285e58
feat: add a miniget command
grunweg 061951d
chore: use parseImports'
grunweg e6c4224
Remove superfluous comment.
grunweg 53d4ce8
Line length.
grunweg 85fa6f4
doc(Cache): mention get- also
grunweg 20ea38a
change: remove miniget; change get instead
grunweg 720d7d8
Use a NameSet instead.
grunweg 8c474bb
Re-instate miniget and miniget-
grunweg 6373327
Fixup
grunweg 30f7047
Merge branch 'master' into MR-cache-miniget
grunweg 084eae6
Merge branch 'master' into MR-cache-miniget
grunweg d3593d5
Update
grunweg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't
hashMemo
already contain the dependency information?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only contains this for all files it has memoized this for. This is mathlib and all
extraRoots
(i.e., arguments passed to it). Running justlake exe cache get
in a dependent project does not parse the files in the downstream project.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse the same code that populates this in miniget?