From da0490c4a2a5dbcb4564dcc210fb7b2fcc798571 Mon Sep 17 00:00:00 2001 From: Louis-Dominique Dubeau Date: Fri, 8 Jun 2018 09:06:36 -0400 Subject: [PATCH] refactor: drop support for versionedSources as comma-separated list BREAKING CHANGE: setting ``versionedSources`` as a comma-separated list of file names is no longer supported. That was deprecated in version 3.0.0. --- index.js | 19 +++++++++---------- test/index.js | 3 --- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/index.js b/index.js index c9791ab..d55b174 100644 --- a/index.js +++ b/index.js @@ -93,17 +93,16 @@ exports.getSources = function getSources(extraSources) { const pkg = JSON.parse(data); const { versionedSources } = pkg; if (versionedSources) { - if (versionedSources instanceof Array) { - sources = sources.concat(versionedSources); - } - else { - if (versionedSources.indexOf(",") !== -1) { - console.warn( // eslint-disable-line no-console - "WARNING: the use of comma in versionedSources is " + - "deprecated."); - } - sources = sources.concat(versionedSources.split(",")); + if (!(versionedSources instanceof Array || + typeof versionedSources === "string")) { + throw new Error( + "versionedSources must be an array or a string"); } + + sources = + sources.concat(versionedSources instanceof Array ? + versionedSources : + [versionedSources]); } return sources; diff --git a/test/index.js b/test/index.js index 6dc64e7..b15831f 100644 --- a/test/index.js +++ b/test/index.js @@ -211,9 +211,6 @@ describe("getSources", () => { makeTest("a single string", ["package.json", "literal.js"], "literal.js"); makeTest("an array", ["package.json", "literal.js", "tsmodule.ts"], ["literal.js", "tsmodule.ts"]); - makeTest("a comma-separated list", - ["package.json", "literal.js", "tsmodule.ts"], - "literal.js,tsmodule.ts"); }); });