refactor: drop support for versionedSources as comma-separated list

BREAKING CHANGE: setting ``versionedSources`` as a comma-separated list of file names is no longer supported. That was deprecated in version 3.0.0.
lddubeau · Jun 8, 2018 · da0490c · da0490c
1 parent b8db171
commit da0490c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/index.js b/index.js
@@ -93,17 +93,16 @@ exports.getSources = function getSources(extraSources) {
             const pkg = JSON.parse(data);
             const { versionedSources } = pkg;
             if (versionedSources) {
-              if (versionedSources instanceof Array) {
-                sources = sources.concat(versionedSources);
-              }
-              else {
-                if (versionedSources.indexOf(",") !== -1) {
-                  console.warn( // eslint-disable-line no-console
-                    "WARNING: the use of comma in versionedSources is " +
-                      "deprecated.");
-                }
-                sources = sources.concat(versionedSources.split(","));
+              if (!(versionedSources instanceof Array ||
+                    typeof versionedSources === "string")) {
+                throw new Error(
+                  "versionedSources must be an array or a string");
               }
+
+              sources =
+                sources.concat(versionedSources instanceof Array ?
+                               versionedSources :
+                               [versionedSources]);
             }
 
             return sources;

diff --git a/test/index.js b/test/index.js
@@ -211,9 +211,6 @@ describe("getSources", () => {
     makeTest("a single string", ["package.json", "literal.js"], "literal.js");
     makeTest("an array", ["package.json", "literal.js", "tsmodule.ts"],
              ["literal.js", "tsmodule.ts"]);
-    makeTest("a comma-separated list",
-             ["package.json", "literal.js", "tsmodule.ts"],
-             "literal.js,tsmodule.ts");
   });
 });