Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no support for PHP 7.3 #282

Closed
aksafan opened this issue Jan 8, 2019 · 5 comments
Closed

There is no support for PHP 7.3 #282

aksafan opened this issue Jan 8, 2019 · 5 comments
Milestone

Comments

@aksafan
Copy link

aksafan commented Jan 8, 2019

There is mdanter/ecc in dependencies of an old version, that required php 7.2 max.
So when i'm trying to add lcobucci/jwt library to my project, i receive and error:
- mdanter/ecc v0.4.5 requires php >=5.6.0, <7.2 -> your PHP version (7.3.0) does not satisfy that requirement.

The fully php 7.* support for this library was arrived in release PHPECC v0.5.0.

It will be very good, if you upgrade mdanter/ecc in your library.

@lcobucci
Copy link
Owner

@aksafan thanks, we're aware and working on it to removing that dependency quite soon. A security review is pending on the ecdsa pr we have open, and then it will be back ported to v3.3.

Sorry about that delay but I really don't want to have potential security issues.

@GrahamCampbell
Copy link

GrahamCampbell commented Jan 27, 2019

Is there anything I can do to help with PHP 7.1-7.3 support, and getting v3.3.0 out the door?

@lcobucci
Copy link
Owner

@GrahamCampbell I've just merged in @Spomky's PR (which is quite interesting in many ways) and am back porting things to v3.3. It would be awesome to have help with the documentation (not sure if the open issues on that are helpful enough).

@lcobucci lcobucci added this to the 3.3.0 milestone Feb 4, 2019
@lcobucci
Copy link
Owner

lcobucci commented Feb 5, 2019

#288 just backported PHP 7.1-7.3 support, can you please change your requirements to 3.3.x-dev and check if things are working fine for you? Important: this is still a development version and shouldn't be used in production yet.

@lcobucci
Copy link
Owner

Preparing the release of v3.3.0 now, so this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants