From b6da49571440ff6146afc4742ac3dddebb14e7d4 Mon Sep 17 00:00:00 2001
From: Eli Bishop <eli@launchdarkly.com>
Date: Mon, 14 Jun 2021 11:26:00 -0700
Subject: [PATCH] add CI jobs for all compatible Node versions (#202)

---
 .circleci/config.yml | 48 +++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 43 insertions(+), 5 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 23fbdd2..09e4d09 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -1,19 +1,56 @@
 version: 2.1
 
 orbs:
-   win: circleci/windows@1.0.0
+   win: circleci/windows@2.4.0
 
 workflows:
   build-and-test-all:
     jobs:
+      # CircleCI's current generation of Node images, cimg/node, allow you to leave the
+      # patch version unpinned, but require you to specify the minor version. The one
+      # exception is cimg/node:current, which will always give us the latest release in
+      # the latest major version-- and the latest major version is where it's most likely
+      # that there would be a new minor version, anyway.
+      # The cimg/ images do not include major versions that were never LTS and are no
+      # longer supported, like 9 and 11, or extremely old ones like 6 and 7. For these,
+      # we fall back to the old circleci/ images, pinned only to the major version.
       - build-test-linux:
           name: latest Node version
-          docker-image: circleci/node:latest
+          docker-image: cimg/node:current
           run-lint: true
       - build-test-linux:
-          name: oldest supported Node version
+          name: Node 16.3
+          docker-image: cimg/node:16.3
+      - build-test-linux:
+          name: Node 15.14
+          docker-image: cimg/node:15.14
+      - build-test-linux:
+          name: Node 14.17
+          docker-image: cimg/node:14.17
+      - build-test-linux:
+          name: Node 13.14
+          docker-image: cimg/node:13.14
+      - build-test-linux:
+          name: Node 12.22
+          docker-image: cimg/node:12.22
+      - build-test-linux:
+          name: Node 11.15
+          docker-image: circleci/node:11
+      - build-test-linux:
+          name: Node 10.24
+          docker-image: cimg/node:10.24
+      - build-test-linux:
+          name: Node 9
+          docker-image: circleci/node:9
+      - build-test-linux:
+          name: Node 8.17
+          docker-image: cimg/node:8.17
+      - build-test-linux:
+          name: Node 7
+          docker-image: circleci/node:7
+      - build-test-linux:
+          name: Node 6
           docker-image: circleci/node:6
-          run-lint: false
       - build-test-windows:
           name: Windows
 
@@ -22,6 +59,7 @@ jobs:
     parameters:
       run-lint:
         type: boolean
+        default: false
       docker-image:
         type: string
     docker:
@@ -50,7 +88,7 @@ jobs:
 
   build-test-windows:
     executor:
-      name: win/vs2019
+      name: win/default
       shell: powershell.exe
     steps:
       - checkout