sqlite: fix memory leak

slumber · mehcode · commit df1b9b06ed07 · 2020-12-17T00:55:45.000-08:00
diff --git a/sqlx-core/src/sqlite/connection/collation.rs b/sqlx-core/src/sqlite/connection/collation.rs
@@ -69,6 +69,8 @@ where
     if r == SQLITE_OK {
         Ok(())
     } else {
+        // The xDestroy callback is not called if the sqlite3_create_collation_v2() function fails.
+        drop(unsafe { Box::from_raw(boxed_f) });
         Err(Error::Database(Box::new(SqliteError::new(handle.as_ptr()))))
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,8 @@ where`
`69`	`69`	`if r == SQLITE_OK {`
`70`	`70`	`Ok(())`
`71`	`71`	`} else {`
	`72`	`+ // The xDestroy callback is not called if the sqlite3_create_collation_v2() function fails.`
	`73`	`+ drop(unsafe { Box::from_raw(boxed_f) });`
`72`	`74`	`Err(Error::Database(Box::new(SqliteError::new(handle.as_ptr()))))`
`73`	`75`	`}`
`74`	`76`	`}`