Skip to content

Commit 38435ca

Browse files
authored
fix(cli): pin clap_derive version (#1381)
When `clap_derive 3.0.0-beta.4` released, new invocations of `cargo install sqlx-cli` would try to compile that against `clap 3.0.0-beta.2` which caused some breakages. Until `clap 3.0.0` proper is released, we need to pin both versions to insure against potential breakages from automatic upgrades. closes #1378
1 parent dd27aa0 commit 38435ca

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

Cargo.lock

+5-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sqlx-cli/Cargo.toml

+4
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,11 @@ sqlx = { version = "0.5.5", path = "..", default-features = false, features = [
3434
"offline",
3535
] }
3636
futures = "0.3"
37+
# FIXME: we need to fix both of these versions until Clap 3.0 proper is released, then we can drop `clap_derive`
38+
# https://github.com/launchbadge/sqlx/issues/1378
39+
# https://github.com/clap-rs/clap/issues/2705
3740
clap = "=3.0.0-beta.2"
41+
clap_derive = "=3.0.0-beta.2"
3842
chrono = "0.4"
3943
anyhow = "1.0"
4044
url = { version = "2.1.1", default-features = false }

0 commit comments

Comments
 (0)