Allow drivers to check for Composer dependencies and update Bedrock driver to use that for "serves" check #1342
Comments
|
@ethanclevenger91 would it be safe to say that this issue is really a proposal that we update the Bedrock driver to check for the |
Merged
|
@mattstauffer exactly. I considered a PR myself but that must have been the one driver I didn't look through to see if any of the others were already doing this 😆 |
mattstauffer
changed the title
app
|
Fixing in #1345, coming out in v4. :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
The Bedrock driver depends on the
appdirectory existing. However, when retrofitting an existing WordPress site into Bedrock, it can sometimes reduce friction/alleviate (potentially unsubstantiated) SEO concerns to simply renameapptowp-contentand update the BedrockCONTENT_DIRconfig accordingly. In this case, the Bedrock driver won't recognize the site. You could name it whatever you want, of course.In the meantime, I've created a custom local driver for this project. Right now, the Bedrock driver looks first for the Bedrock autoloader mu-plugin. This could be determined by parsing the
composer.jsonfile in the root rather than traversing to the best guess at the location of themu-pluginsdirectory. It's possible these rules were written before the autoloader was a Composer dependency and are due for an update, or at least an expansion.Something like (complete pseudo-code here)...
if($composer->requires->includes('roots/bedrock-autoloader')) || ...Steps To Reproduce:
appdirectory towp-contentconfig/application.php, update theCONTENT_DIRconfiguration to/wp-content.valet parkorvalet linkor whateverDiagnosis
sw_vers
valet --version
cat ~/.config/valet/config.json
{ "tld": "test", "loopback": "127.0.0.1", "paths": [ "/Users/ethanclevenger/code" ] }cat ~/.composer/composer.json
{ "require": { "laravel/valet": "^3.2" } }composer global diagnose
composer global outdated
ls -al /etc/sudoers.d/
brew config
brew services list
brew list --formula --versions | grep -E "(php|nginx|dnsmasq|mariadb|mysql|mailhog|openssl)(@\d\..*)?\s"
brew outdated
brew tap
php -v
PHP 8.0.27 (cli) (built: Jan 3 2023 22:24:41) ( NTS ) Copyright (c) The PHP Group Zend Engine v4.0.27, Copyright (c) Zend Technologies with Xdebug v3.2.0, Copyright (c) 2002-2022, by Derick Rethans with Zend OPcache v8.0.27, Copyright (c), by Zend Technologieswhich -a php
php --ini
nginx -v
curl --version
php --ri curl
~/.composer/vendor/laravel/valet/bin/ngrok version
ls -al ~/.ngrok2
brew info nginx
brew info php
brew info openssl
openssl version -a
openssl ciphers
sudo nginx -t
which -a php-fpm
/opt/homebrew/opt/php/sbin/php-fpm -v
PHP 8.2.1 (fpm-fcgi) (built: Jan 5 2023 19:28:05) Copyright (c) The PHP Group Zend Engine v4.2.1, Copyright (c) Zend Technologies with Zend OPcache v8.2.1, Copyright (c), by Zend Technologiessudo /opt/homebrew/opt/php/sbin/php-fpm -y /opt/homebrew/etc/php/8.0/php-fpm.conf --test
ls -al ~/Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchDaemons | grep homebrew
ls -al /Library/LaunchDaemons | grep "com.laravel.valet."
ls -aln /etc/resolv.conf
cat /etc/resolv.conf
ifconfig lo0
sh -c 'echo "------\n/opt/homebrew/etc/nginx/valet/valet.conf\n---\n"; cat /opt/homebrew/etc/nginx/valet/valet.conf | grep -n "# valet loopback"; echo "\n------\n"'
sh -c 'for file in ~/.config/valet/dnsmasq.d/*; do echo "------\n~/.config/valet/dnsmasq.d/$(basename $file)\n---\n"; cat $file; echo "\n------\n"; done'
sh -c 'for file in ~/.config/valet/nginx/*; do echo "------\n~/.config/valet/nginx/$(basename $file)\n---\n"; cat $file | grep -n "# valet loopback"; echo "\n------\n"; done'
The text was updated successfully, but these errors were encountered: