Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Lumen running on subdirectory #22

Closed
wants to merge 1 commit into from
Closed

Compatibility with Lumen running on subdirectory #22

wants to merge 1 commit into from

Conversation

dougogodinho
Copy link

The Application method getPathInfo() do not undestend when we are running on subdirectory... the Request do!

The Application method getPathInfo() do not undestend when we are running on subdirectory... the Request do!
@ghost
Copy link

ghost commented Apr 15, 2015

This fix take 10ms about performance
I have submit a PR #21 that following criteria of Lumen.

@dougogodinho
Copy link
Author

dougogodinho commented Apr 15, 2015 via email

@taylorotwell
Copy link
Member

Just pass a request via the run() method of your index.php file.

@pvormittag
Copy link

I've run into this situation as well. Many of my team members develop locally within a single shared host, separating projects with sub-directories.

@taylorotwell As you mention, passing a request to run() fixes the issue, however it seems odd to pass $app its own request reference?

/*
|--------------------------------------------------------------------------
| Run The Application
|--------------------------------------------------------------------------
|
| Once we have the application, we can handle the incoming request
| through the kernel, and send the associated response back to
| the client's browser allowing them to enjoy the creative
| and wonderful application we have prepared for them.
|
*/

$app->run($app->request);

@ghost
Copy link

ghost commented Apr 16, 2015

$app->request will capture information of the current request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants