Fix error 404 if not run Lumen in root #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Previous PR, i have missing a case that if uri contains a path like sub-folder name
ghost
closed this
ghost
reopened this
ghost
changed the title
| @@ -1324,8 +1324,12 @@ protected function getMethod() | |||
| public function getPathInfo() | |||
| { | |||
| $query = isset($_SERVER['QUERY_STRING']) ? $_SERVER['QUERY_STRING'] : ''; | |||
|
|
|||
| return '/'.ltrim(str_replace('?'.$query, '', $_SERVER['REQUEST_URI']), '/'); | |||
| $folder = dirname($_SERVER['SCRIPT_NAME']); | |||
There was a problem hiding this comment.
Ya, if i run lumen in http://localhost/folder/folder/ then the $folder is /folder/folder
If run in root domain, the $folder is /
|
Oh, right, I see. You can't run Lumen in a subfolder. |
|
So then will this fixed ? |
|
It's not going to be fixed. It's not supported. |
|
👎 people must run lumen in root domain. |
|
@ptcong That is also true for Laravel. |
|
With laravel and all other framework i have used, i can run in subfolder as well. |
|
We don't encourage it in Laravel, and we pretend you can't in the docs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getPathInfo()give wrong uri if Lumen run in a sub folder, this PR to resolve the problem.