Avoid EmptyScope.cloneScope crashing, eg on missing references #16314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this manually with |
smarter
reviewed
Nov 14, 2022
smarter
requested changes
Nov 14, 2022
There was a problem hiding this comment.
If you want to test this change, you could add an sbt scripted test in https://github.com/lampepfl/dotty/tree/main/sbt-test/scala2-compat
dwijnand
force-pushed
the
shapeless-crash
branch
from
49be95a to
2f78328
Compare
dwijnand
changed the title
I tried, but there's no way to distinguishing a clear compilation error from a compilation crash. |
smarter
approved these changes
Nov 17, 2022
dwijnand
force-pushed
the
shapeless-crash
branch
from
2f78328 to
f8273c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.