Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload assets in parallel in the CLI #607

Closed
QuiiBz opened this issue Feb 21, 2023 · 1 comment · Fixed by #620
Closed

Upload assets in parallel in the CLI #607

QuiiBz opened this issue Feb 21, 2023 · 1 comment · Fixed by #620
Labels
feature good first issue package/cli
Milestone
Beta

Comments

@QuiiBz
Copy link
Member

QuiiBz commented Feb 21, 2023

When deploying a function using lagon deploy, assets (if a --public directory is specified) are uploaded through S3 sequentially. This step can be faster by uploading assets in parallel, either using rayon or spawning tokio threads and joining them together.

lagon/crates/cli/src/utils/deployments.rs

Line 391 in 75ca4b5

for (asset, url) in assets_urls {

@QuiiBz QuiiBz added this to Roadmap Feb 21, 2023
@QuiiBz QuiiBz converted this from a draft issue Feb 21, 2023
@QuiiBz QuiiBz added this to the Beta milestone Feb 23, 2023
@ming535 ming535 mentioned this issue Feb 26, 2023
Merged
@QuiiBz QuiiBz linked a pull request Feb 26, 2023 that will close this issue
feat(cli): parallel upload of assets #620
Merged
@QuiiBz
Copy link
Member Author

QuiiBz commented Feb 26, 2023

Done by @ming535 in #620, thanks!

@QuiiBz QuiiBz closed this as completed Feb 26, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue package/cli
Projects
Roadmap
Status: Done
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

feat(cli): parallel upload of assets ming535/lagon
1 participant
@QuiiBz