Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GNOME 3.38 #10

Open
1over137 opened this issue Oct 22, 2020 · 5 comments
Open

Support GNOME 3.38 #10

1over137 opened this issue Oct 22, 2020 · 5 comments

Comments

@1over137
Copy link

The extension breaks after the 3.38 update.

@floringogianu
Copy link

floringogianu commented Oct 24, 2020

Can confirm this. Tried to reinstall it but no use either.

@mirrorsonthewall
Copy link

I don't know how desaturate_all works but as a temporary fix or to compare code to get it working, tint-all seems to work: https://extensions.gnome.org/extension/1471/tint-all/

@Jumanjii
Copy link

Jumanjii commented Nov 26, 2020

Thanks to @YurchenkoSt to have opened a PR with the fix.

To @mirrorsonthewall and other people that will have this issue:

While the fix being review, I wrote for fun a script that will fix your extension locally using the PR branch.

You can use it to apply the fix from the branch of the PR and use it again when the PR will be merged in the main repository.

But if you don't want to download my script because you don't know me or whatever (and I swear it's readable 🙈 )
just copy/paste the following in your terminal:

cd ~/.local/share/gnome-shell/extensions/[email protected]
git remote add fix-3.8 [email protected]:YurchenkoSt/desaturate_all.git
git fetch fix-3.8
git cherry-pick eed917643610b7f930ff6a6e2ac124d7d22fc49b

(edited ps: you can thanks again YurchenkoSt to share the way to ensure you are not fetching his future hypothetical malicious code 😂)

@YurchenkoSt
Copy link

@Jumanjii Or better yet, use the specific commit instead of the branch. That won't change and no trust will be needed 😃

@Jumanjii
Copy link

@YurchenkoSt I thought about it while writing the script, but I was like, "it would still be possible to --amend" 🤦‍♂️
It's only now with a night of sleep that it appears to me that that would change the hash 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants