From d2e8827108ef9cf88228172faf065824fc8644bb Mon Sep 17 00:00:00 2001 From: Gyubong Lee Date: Sat, 27 Jul 2024 03:09:11 +0000 Subject: [PATCH] fix: Silent failure of DockerAgent.push_image --- src/ai/backend/agent/docker/agent.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/ai/backend/agent/docker/agent.py b/src/ai/backend/agent/docker/agent.py index 5228993fa6f..43274d0f4f1 100644 --- a/src/ai/backend/agent/docker/agent.py +++ b/src/ai/backend/agent/docker/agent.py @@ -1343,7 +1343,13 @@ async def push_image(self, image_ref: ImageRef, registry_conf: ImageRegistry) -> } async with closing_async(Docker()) as docker: - await docker.images.push(image_ref.canonical, auth=auth_config) + result = await docker.images.push(image_ref.canonical, auth=auth_config) + + # Why is this list? It contradicts the API documentation. + result_ = cast(list, result) + + if error := result_[-1].get("error"): + raise RuntimeError(f"Failed to push image: {error}") async def pull_image(self, image_ref: ImageRef, registry_conf: ImageRegistry) -> None: auth_config = None