Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to use this linter with golangci-lint #1

Closed
kyoh86 opened this issue Jun 25, 2020 · 2 comments
Closed

how to use this linter with golangci-lint #1

kyoh86 opened this issue Jun 25, 2020 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@kyoh86
Copy link
Owner

kyoh86 commented Jun 25, 2020

I've to write it in README.md

looppinter is not bound in golangci-lint since
golangci/golangci-lint#1041 (comment)

If you are going to include only one, please include exportloopref. No body wants false positives from their linter.

I think so too.
But if anybody want to use this one, I want help them.

@kyoh86 kyoh86 self-assigned this Jun 25, 2020
@kyoh86 kyoh86 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jun 25, 2020
@kyoh86
Copy link
Owner Author

kyoh86 commented Jun 25, 2020

(:thought_balloon: どうでもいいけど、Scopelintを潰してこういう二択にしたのが、
結果的にこうして誰かの選択の余地を生み、そして実際に選択してもらえたという体験は嬉しいものだ)

@kyoh86
Copy link
Owner Author

kyoh86 commented Jun 28, 2020

golangci-lint uses go 1.12. I wont use old go.
I give up building plugin for golangci-lint.

ref: https://golangci-lint.run/contributing/new-linters/#create-a-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant