Add automatic RefreshControl offset adjustment behavior #281
Conversation
| switch control.model.offsetAdjustmentBehavior { | ||
| case .displayWhenRefreshing(let animate): | ||
| let contentOffset = CGPoint(x: 0, y: -control.view.frame.height - view.safeAreaInsets.top) | ||
| view.setContentOffset(contentOffset, animated: animate) |
There was a problem hiding this comment.
As modeled right now, it'll always scroll to the top of the list when refreshing begins, right? Is that desired?
There was a problem hiding this comment.
(Eg, seems like maybe it should only become visible if the list is already at the top?)
There was a problem hiding this comment.
This is more of a product/design question I feel like, but this is generally why I like to avoid using the refresh control to indicate a programmatic refresh. Perhaps this should also be configurable?
There was a problem hiding this comment.
For the feature that prompted this change, we do want to scroll to the top when we start refreshing through a workflow action, but it's a good point, I also think it should be configurable.
Would you rather add a scrollToTop associated value to displayWhenRefreshing, or have a new scrollToTopWhenRefreshing case?
There was a problem hiding this comment.
I don't have a huge preference, an associated scrollToTop makes sense to me!
There was a problem hiding this comment.
Would be great to update the demo for this case too!
There was a problem hiding this comment.
@kylebshr added the parameter and updated the demo!
Co-authored-by: Kyle Bashour <[email protected]>
Goal
When
RefreshControl.isRefreshingbecomestruebecause of a change of state that is not caused by the user pulling to refresh (for example changing filters or tapping retry from an error cell), we want to be able to display the refresh control to indicate that loading is in progress.Implementation Details
RefreshControlto allow consumers to opt into this behavioradjustContentOffsetForRefreshControlmethod inPresentationStateto adjust the offset based on the current state of the refresh controlupdatePresentationStateinListViewafter content updates and before performing any auto scroll actionsDemo
iOS 12
auto.refresh.control.ios.12.mov
iOS 13
auto.refresh.control.ios.13.mov
iOS 14
auto.refresh.control.ios.14.mov