Add a didPerform callback for AutoScrollAction. #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
force-pushed
the
kve/autoscroll-did-perform
branch
from
bc6d612 to
366602d
Compare
kylebshr
approved these changes
Oct 29, 2020
kyleve
force-pushed
the
kve/autoscroll-did-perform
branch
from
25c024f to
a7a8881
Compare
kyleve
commented
Oct 30, 2020
kylebshr
approved these changes
Oct 30, 2020
kyleve
commented
Oct 31, 2020
kyleve
commented
Oct 31, 2020
kyleve
force-pushed
the
kve/autoscroll-did-perform
branch
from
d49a9bd to
cca4ddc
Compare
kyleve
commented
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way actions don't occur in the
shouldPerformmethod, which should be idempotent.