Fix autolayout sizing for items and headers/footers #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsillik
reviewed
Oct 29, 2020
Demo/Sources/Demos/Demo Screens/AutoLayoutDemoViewController.swift
Outdated
Show resolved
Hide resolved
nsillik
reviewed
Oct 29, 2020
Demo/Sources/Demos/Demo Screens/AutoLayoutDemoViewController.swift
Outdated
Show resolved
Hide resolved
Demo/Sources/Demos/Demo Screens/AutoLayoutDemoViewController.swift
Outdated
Show resolved
Hide resolved
Demo/Sources/Demos/Demo Screens/AutoLayoutDemoViewController.swift
Outdated
Show resolved
Hide resolved
kylebshr
reviewed
Oct 29, 2020
ListableUI/Sources/Internal/ItemCell.ContentViewContainer.swift
Outdated
Show resolved
Hide resolved
kyleve
commented
Oct 29, 2020
kyleve
commented
Oct 29, 2020
kyleve
commented
Oct 29, 2020
kyleve
commented
Oct 29, 2020
kyleve
commented
Oct 29, 2020
kyleve
commented
Oct 29, 2020
kyleve
commented
Oct 29, 2020
kyleve
commented
Oct 29, 2020
kylebshr
reviewed
Oct 29, 2020
kyleve
commented
Oct 29, 2020
|
|
||
| let size : CGSize = { |
There was a problem hiding this comment.
If UIView.noIntrinsicSize gets passed instead of zero, does the same thing happen? Nicer for contextual understanding
There was a problem hiding this comment.
UIView.layoutFittingCompressedSize has a size of zero, so could use the width/height of it for context. UIView.noIntrinsicSize is -1... might do the same thing but not sure
kyleve
force-pushed
the
kve/fix-autolayout-sizing
branch
from
5256457 to
f7cb77a
Compare
kyleve
commented
Nov 29, 2020
kyleve
commented
Nov 29, 2020
…zing * origin/main: Move CI to GitHub Actions Add circle CI config Xcode 11 build fixes Fix handling of the frame changing properly Update docs Prepare to release 0.12.0
kyleve
force-pushed
the
kve/fix-autolayout-sizing
branch
from
a4e6e18 to
60fd845
Compare
kyleve
force-pushed
the
kve/fix-autolayout-sizing
branch
from
e4fcb95 to
527e920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.