Cleanup scroll insets stuff #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
commented
Oct 22, 2020
kyleve
commented
Oct 22, 2020
kyleve
changed the title
kyleve
force-pushed
the
kve/oops-forgot-about-scrollInsets
branch
2 times, most recently
from
3af1677 to
bf13096
Compare
kyleve
commented
Oct 22, 2020
kyleve
force-pushed
the
kve/oops-forgot-about-scrollInsets
branch
from
bf13096 to
e1b0262
Compare
kyleve
force-pushed
the
kve/oops-forgot-about-scrollInsets
branch
from
e1b0262 to
6077f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed up some incorrect code from a very early version of Listable: Rename scrollInsets to scrollIndicatorInsets since that's what it was really meant for; and then clean up the inset handling within ListView itself to centralize it in one place.