Adjust the keyboard inset more than before #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
commented
Aug 27, 2020
Demo/Sources/Demos/Demo Screens/AppearsLaterWithKeyboardViewController.swift
Outdated
Show resolved
Hide resolved
kyleve
commented
Aug 27, 2020
kyleve
commented
Aug 27, 2020
kyleve
commented
Aug 27, 2020
kyleve
commented
Aug 28, 2020
| /// | ||
| /// **WARNING**: You must **not** call this method outside of tests. Doing so will cause a fatal error. | ||
| /// | ||
| func testing_forceLayoutUpdateNow() |
There was a problem hiding this comment.
This isnt necessarily related, but added in this PR since I was doing some snapshot testing attempts (turns out getting this working with the keyboard is a PITA), but it did resolve some async rendering issues.
kyleve
force-pushed
the
kve/adjust-keyboard-but-more-than-before
branch
from
822f347 to
213c438
Compare
kylebshr
approved these changes
Aug 28, 2020
…ure it is always correct
kyleve
force-pushed
the
kve/adjust-keyboard-but-more-than-before
branch
from
213c438 to
745ac28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the keyboard inset in both setFrame and layoutSubviews, to ensure the inset is always correct when we've changed either layout or positioning.