Performance Improvements #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
force-pushed
the
kve/diff-fast-path
branch
from
6d362ac to
db0a1cc
Compare
kyleve
commented
Jul 1, 2020
| @@ -83,6 +84,7 @@ fileprivate struct XcodePreviewDemoContent : BlueprintItemContent, Equatable | |||
| } | |||
| } | |||
|
|
|||
| #if DEBUG && canImport(SwiftUI) && !arch(i386) && !arch(arm) | |||
There was a problem hiding this comment.
Fixes building for profiling in Instruments
kyleve
commented
Jul 1, 2020
| @@ -8,17 +8,21 @@ | |||
| import Foundation | |||
|
|
|||
|
|
|||
| public final class AnyIdentifier : Hashable, CustomDebugStringConvertible | |||
| public class AnyIdentifier : Hashable, CustomDebugStringConvertible | |||
There was a problem hiding this comment.
Changing this to a class hierarchy allows free bridging to the Any type
kyleve
commented
Jul 1, 2020
| @@ -8,7 +8,7 @@ | |||
| import Foundation | |||
|
|
|||
|
|
|||
| struct ArrayDiff<Element> | |||
| struct ArrayDiff<Element, Identifier:Hashable> | |||
There was a problem hiding this comment.
Not wrapping in AnyHashable saves many allocs and function calls; which add up.
kyleve
commented
Jul 1, 2020
| @@ -27,14 +27,6 @@ struct SectionedDiff<Section, Item> | |||
| ) | |||
| } | |||
|
|
|||
| static func calculate(on queue : DispatchQueue, old : [Section], new: [Section], configuration : Configuration, completion : @escaping (SectionedDiff) -> ()) | |||
kyleve
commented
Jul 1, 2020
| @@ -8,7 +8,7 @@ | |||
| import Foundation | |||
|
|
|||
|
|
|||
| struct SectionedDiff<Section, Item> | |||
| struct SectionedDiff<Section, SectionIdentifier:Hashable, Item, ItemIdentifier:Hashable> | |||
There was a problem hiding this comment.
Converting to the direct type saves trampolining through AnyHashable, which is faster for large diffs.
kyleve
commented
Jul 1, 2020
| @@ -9,23 +9,6 @@ import XCTest | |||
| import Listable | |||
|
|
|||
|
|
|||
| class AnyIdentifierTests: XCTestCase | |||
There was a problem hiding this comment.
Now an abstract type; no longer useful to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.