Skip to content

Commit f5e7884

Browse files
author
Release Manager
committed
sagemathgh-37970: Fix sign error in the Kerr metric of the manifold catalog
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> In the Kerr spacetime constructed from the manifold catalog (i.e. returned by `manifolds.Kerr`), there was an error in the sign of the g_{03} component of the metric tensor with respect to Boyer-Lindquist coordinates. This is fixed here. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37970 Reported by: Eric Gourgoulhon Reviewer(s): Travis Scrimshaw
2 parents 4e0bbaf + 5731edb commit f5e7884

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

build/pkgs/configure/checksums.ini

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
tarball=configure-VERSION.tar.gz
2-
sha1=599182ff950764df31446f7bf8350499717dc76e
3-
md5=06e0643f4948ad4b4c87d2530d026a1f
4-
cksum=4286155814
2+
sha1=fa7d8e54b6563001256eac25159c14cdb3619004
3+
md5=15cf5e8fb1b18afc819922d8218721a8
4+
cksum=2753177283
+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e77b3df44ade2f51f750de90ad255f772a933776
1+
8eaeb3e77110a5e6b866f7cded0a3e4953fd6c3f

src/sage/manifolds/catalog.py

+11-3
Original file line numberDiff line numberDiff line change
@@ -127,14 +127,19 @@ def Kerr(m=1, a=0, coordinates="BL", names=None):
127127
4-dimensional Lorentzian manifold M
128128
sage: K.atlas()
129129
[Chart (M, (t, r, th, ph))]
130+
131+
The Kerr metric in Boyer-Lindquist coordinates (cf. :wikipedia:`Kerr_metric`)::
132+
130133
sage: K.metric().display()
131134
g = (2*m*r/(a^2*cos(th)^2 + r^2) - 1) dt⊗dt
132-
+ 2*a*m*r*sin(th)^2/(a^2*cos(th)^2 + r^2) dt⊗dph
135+
- 2*a*m*r*sin(th)^2/(a^2*cos(th)^2 + r^2) dt⊗dph
133136
+ (a^2*cos(th)^2 + r^2)/(a^2 - 2*m*r + r^2) dr⊗dr
134137
+ (a^2*cos(th)^2 + r^2) dth⊗dth
135-
+ 2*a*m*r*sin(th)^2/(a^2*cos(th)^2 + r^2) dph⊗dt
138+
- 2*a*m*r*sin(th)^2/(a^2*cos(th)^2 + r^2) dph⊗dt
136139
+ (2*a^2*m*r*sin(th)^2/(a^2*cos(th)^2 + r^2) + a^2 + r^2)*sin(th)^2 dph⊗dph
137140
141+
The Schwarzschild spacetime with the mass parameter set to 1::
142+
138143
sage: K.<t, r, th, ph> = manifolds.Kerr()
139144
sage: K
140145
4-dimensional Lorentzian manifold M
@@ -144,6 +149,9 @@ def Kerr(m=1, a=0, coordinates="BL", names=None):
144149
sage: K.default_chart().coord_range()
145150
t: (-oo, +oo); r: (0, +oo); th: (0, pi); ph: [-pi, pi] (periodic)
146151
152+
153+
The Kerr spacetime in Kerr coordinates::
154+
147155
sage: m, a = var('m, a')
148156
sage: K.<t, r, th, ph> = manifolds.Kerr(m, a, coordinates="Kerr")
149157
sage: K
@@ -205,7 +213,7 @@ def Kerr(m=1, a=0, coordinates="BL", names=None):
205213
g[0, 0], g[1, 1], g[2, 2], g[3, 3] = -(1-2*m*r/rho**2), \
206214
rho**2/(r**2-2*m*r+a**2), rho**2, \
207215
(r**2+a**2+2*m*r*a**2/rho**2*sin(th)**2)*sin(th)**2
208-
g[0, 3] = 2*m*r*a*sin(th)**2/rho**2
216+
g[0, 3] = -2*m*r*a*sin(th)**2/rho**2
209217
return M
210218

211219
raise NotImplementedError("coordinates system not implemented, see help"

0 commit comments

Comments
 (0)