[HOTFIX] Add a warning when a filter is set when looking at documents and users #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 35 35
Lines 793 793
=======================================
Hits 667 667
Misses 126 126Continue to review full report at Codecov.
|
jenow
changed the title
Aschen
approved these changes
Mar 12, 2019
scottinet
suggested changes
Mar 13, 2019
Co-Authored-By: jenow <[email protected]>
etrousset
approved these changes
Mar 13, 2019
scottinet
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
When a filter is set when looking at documents it is not abvious and it happens often for user to think there are missing documents but really they are filtered so I added a warning when a filter is set.
fix #333
Other
Removed the patch rule from codecov as it is useless and run in a forever loop anyway.
Note
I didn't change the version as I am going to do a batch of hotfix before patching this version