Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: leaderboard #20

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Conversation

dipenkhatri7
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2023 6:26pm

@erwinschrodinger1
Copy link
Collaborator

Please review new response type and design the front-end accordingly.

Thank you for you contributions in KUOSC.

@aadarshadhakalg
Copy link
Member

Screenshot_20230901-193517
Hi @dipenkhatri7 , can you please fix the mobile too? Thanks 👍

@dipenkhatri7
Copy link
Contributor Author

Front-end changes are completed according to new responses, including responsiveness. Please review. Thanks! 🙂

@erwinschrodinger1
Copy link
Collaborator

@dipenkhatri7 can you please change the ip to kuosc's ip. Currently it is pointing local host. Also please resolve the merge conflict at package-lock.json. Thank you!

@erwinschrodinger1
Copy link
Collaborator

@dipenkhatri7 can you please address the issue asap!

@erwinschrodinger1
Copy link
Collaborator

erwinschrodinger1 commented Sep 12, 2023

@dipenkhatri7
image
The image looks distorted in mobile view. Also can you please solve the merge issue at package-lock.json.

Moreover, Can you please add lazy load while loading the data.

Thank you for contributing.

@aadarshadhakalg
Copy link
Member

@dipenkhatri7 Can you quickly fix the responsiveness issue. So that we can merge this PR and close the issue. Thanks :)

@dipenkhatri7
Copy link
Contributor Author

@aadarshadhakalg @erwinschrodinger1 Can you review all the changes? 🙌

@erwinschrodinger1
Copy link
Collaborator

Looks good for me @aadarshadhakalg can you please review it once.

@erwinschrodinger1 erwinschrodinger1 merged commit a33142e into kuosc2005:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants