Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of mesh in ExternalService doesn't change it's ownerReference #8721

Open
lukidzi opened this issue Dec 22, 2023 · 6 comments
Open

Change of mesh in ExternalService doesn't change it's ownerReference #8721

lukidzi opened this issue Dec 22, 2023 · 6 comments
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lukidzi
Copy link
Contributor

lukidzi commented Dec 22, 2023

What happened?

  1. Create ExternalService
apiVersion: kuma.io/v1alpha1
kind: ExternalService
mesh: default
metadata:
  name: httpbin
spec:
  tags:
    kuma.io/service: httpbin
    kuma.io/protocol: http 
  networking:
    address: httpbin.org:443
  1. Create other mesh with different name
  2. Create the same ExternalService but for other mesh
apiVersion: kuma.io/v1alpha1
kind: ExternalService
mesh: mesh-1
metadata:
  name: httpbin
spec:
  tags:
    kuma.io/service: httpbin
    kuma.io/protocol: http 
  networking:
    address: httpbin.org:443
  1. Check the ExternalService object you can notice that ownerReference points to the old mesh
image
@lukidzi lukidzi added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Dec 22, 2023
@michaelbeaumont
Copy link
Contributor

I wonder if we should be setting the owner reference at all? It's not like changing anything on the Mesh results in changes on the ExternalService..

@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 2, 2024
@jakubdyszkiewicz
Copy link
Contributor

jakubdyszkiewicz commented Jan 2, 2024

Triage: try other policies as well. Check if we have a validation on changing the mesh of the resource.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Apr 2, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 3, 2024
@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Jul 10, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Oct 21, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 21, 2025
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

4 participants