Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default resources shouldn't include their mesh in their name #4902

Closed
michaelbeaumont opened this issue Aug 24, 2022 · 1 comment
Closed

Default resources shouldn't include their mesh in their name #4902

michaelbeaumont opened this issue Aug 24, 2022 · 1 comment
Labels
kind/cleanup Cleanup/refactor an existing component/code kind/improvement Improvement on an existing feature triage/duplicated already exists

Comments

@michaelbeaumont
Copy link
Contributor

What happened?

We create default resources like the TrafficPermission allow-all-default for the default mesh. This is unnecessary because these resources are already unique per mesh so we can skip adding the mesh suffix. This sort of feels like a breaking change so maybe 2.0?
@michaelbeaumont michaelbeaumont added triage/pending This issue will be looked at on the next triage meeting kind/cleanup Cleanup/refactor an existing component/code kind/improvement Improvement on an existing feature labels Aug 24, 2022
@jakubdyszkiewicz
Copy link
Contributor

Unfortunately, in this case, we would have a clash on Kubernetes.

xref #3837

@jakubdyszkiewicz jakubdyszkiewicz closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2022
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it triage/duplicated already exists and removed triage/pending This issue will be looked at on the next triage meeting triage/accepted The issue was reviewed and is complete enough to start working on it labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Cleanup/refactor an existing component/code kind/improvement Improvement on an existing feature triage/duplicated already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelbeaumont @jakubdyszkiewicz