Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Textarea): autoResize時にvalue, defaultValueの初期値でも高さを反映するように修正 #5330

Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix(Textarea): autoResize時にvalue, defaultValueの初期値でも高さを反映するように修正 #5330

merged 2 commits into from
Jan 28, 2025

Conversation

Qs-F
Copy link
Contributor

@Qs-F Qs-F commented Jan 24, 2025

関連URL

https://kufuinc.slack.com/archives/C06KVP5PL23/p1737614015187009

概要

autoResize時にvalue, defaultValueの初期値でも高さを反映するように修正

変更内容

  • autoResize時にvalue, defaultValueの初期値でも高さを反映するように修正
  • 軽微なリファクタリング

確認方法

  • 複数行のvalue または defaultValue と autoResize を設定した状態で初期レンダリング時に高さが反映されていることを確認

@Qs-F Qs-F requested a review from a team as a code owner January 24, 2025 09:22
@Qs-F Qs-F requested review from yt-ymmt and uknmr and removed request for a team January 24, 2025 09:22
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 24, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5330

commit: 602c81c

@Qs-F Qs-F enabled auto-merge (squash) January 28, 2025 09:35
@Qs-F Qs-F merged commit 8d09ffa into master Jan 28, 2025
10 of 11 checks passed
@Qs-F Qs-F deleted the fix/textarea/initial-rows-when-autosizing branch January 28, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yt-ymmt yt-ymmt yt-ymmt approved these changes

@uknmr uknmr Awaiting requested review from uknmr uknmr is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qs-F @yt-ymmt