Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AppHeader): AppNaviを使うように修正 #5296

Merged
merged 4 commits into from
Jan 23, 2025
Merged

fix(AppHeader): AppNaviを使うように修正 #5296

merged 4 commits into from
Jan 23, 2025

Conversation

Qs-F
Copy link
Contributor

@Qs-F Qs-F commented Jan 16, 2025 •
edited
Loading

関連URL

AppHeader内で使われていたナビゲーションを、AppNaviを使うようにした

概要

desktopのAppHeaderのみ、AppHeader内で使われていたナビゲーションをAppNaviを使うように修正

変更内容

  • 独自で作られていたナビゲーションのコンポーネント類をAppNaviの対応するコンポーネントに置き換え
  • buttons propsを使うのをやめ、childrenで渡すように修正

確認方法

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 17, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5296

commit: 99e53c4

@Qs-F Qs-F marked this pull request as ready for review January 17, 2025 11:01
@Qs-F Qs-F requested a review from a team as a code owner January 17, 2025 11:01
@Qs-F Qs-F requested review from moshisora, s-sasaki-0529 and nabeliwo and removed request for a team January 17, 2025 11:01
@Qs-F
Copy link
Contributor Author

Qs-F commented Jan 20, 2025

@nabeliwo この辺お気持ちをお持ちな気がするので、見てもらえると助かります！ (全然まったく急ぎではないのでお手漉きで大丈夫です！)

nabeliwo
nabeliwo reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@nabeliwo nabeliwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます！！！

1点、元の方だとグループ化されたドロップダウンの中に current: true があった場合にアクティブっぽい見た目になっているっていうのがあったのですが、それがなくなっちゃったっぽいです！
(そもそもこれが必要かどうかという説もあります)

image

@Qs-F
Copy link
Contributor Author

Qs-F commented Jan 21, 2025

@nabeliwo ありがとうございます！
AppNaviDropdownMenu内の選択中項目の視覚的装飾は #5193 このPRで修正予定なので、ここはこれでいかさせてもらえると助かります…！

nabeliwo
nabeliwo approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@nabeliwo nabeliwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど、理解です！LGTM 🎉

uknmr
uknmr approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@uknmr uknmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@Qs-F Qs-F merged commit f71c333 into master Jan 23, 2025
19 checks passed
@Qs-F Qs-F deleted the fix/appheader/use-appnavi-dropdown-menu-group-instead-of-unique-implementation branch January 23, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabeliwo nabeliwo nabeliwo approved these changes

@uknmr uknmr uknmr approved these changes

@moshisora moshisora Awaiting requested review from moshisora moshisora is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

@s-sasaki-0529 s-sasaki-0529 Awaiting requested review from s-sasaki-0529 s-sasaki-0529 is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qs-F @nabeliwo @uknmr