Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import hcl instead of inlining #46

Closed
jmatsushita opened this issue Jun 25, 2021 · 10 comments · Fixed by #110
Closed

Import hcl instead of inlining #46

jmatsushita opened this issue Jun 25, 2021 · 10 comments · Fixed by #110
Assignees
Labels
good first issue Good for newcomers

Comments

@jmatsushita
Copy link

jmatsushita commented Jun 25, 2021

Hello,

I see there is a examples/tf-native folder with *.tf files. Is it possible to use external *.tf files instead of using spec.hcl yaml blocks?

Thanks!

Jun

@jmatsushita
Copy link
Author

Also curious about pointing to a root folder containing *.tf files.

@jmatsushita
Copy link
Author

The use case would be to allow operators to terraform apply from an admin workstation for iterative deployments before committing to a IaC repo.

@zzxwill
Copy link
Collaborator

zzxwill commented Jun 26, 2021

@jmatsushita examples/tf-native folder stores those Terraform native .hcl and .json configuration files which are the source of those .yaml blocks. They can help quickly validate the configuration and help continuously maintain the Configuration .yaml files.

As this controller will be deployed to a Kubernetes controller, pointing to a root folder won't be possible unless we find a way to mounting them to the container, in which the controller run.

But we definitely can support a Github repo or folder URL, or a shared object storage URL, like OSS. Then we can have an alternative to inlining Terraform configurations. Does it match your requirement?

@roberthstrand
Copy link

I'm looking through some of the projects related to running Terraform with an Operator or Controller method, and personally it really detracts to the experience if I cannot use a git repository to store .hcl files and have it be picked up by the controller as the source.

@zzxwill zzxwill self-assigned this Jul 23, 2021
@zzxwill zzxwill added the good first issue Good for newcomers label Jul 23, 2021
@zzxwill
Copy link
Collaborator

zzxwill commented Jul 23, 2021

@roberthstrand Thanks for your feedback. The remote HCL git repo support will be implemented soon. Thanks.

@Belyenochi
Copy link

I would like apply for this project under the LFX mentorship program. I have read the previous comments and the requirements you mentioned. Looking forward to it. :)

@zzxwill
Copy link
Collaborator

zzxwill commented Aug 13, 2021

@Belyenochi Looking forward to your contribution:)

@zzxwill
Copy link
Collaborator

zzxwill commented Sep 24, 2021

@jmatsushita @roberthstrand , it's supported in #110 .

@roberthstrand
Copy link

Excellent, thank you for the update. I will give it a spin this weekend.

@zzxwill zzxwill linked a pull request Oct 12, 2021 that will close this issue
@zzxwill
Copy link
Collaborator

zzxwill commented Oct 12, 2021

Based on this feature, sub-folders of a git repo to indicate the HCL file location will be supported #124 .

@zzxwill zzxwill closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants