Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Kubectl executor feature as a plugin #841

Closed
huseyinbabal opened this issue Nov 8, 2022 · 3 comments
Closed

Extract Kubectl executor feature as a plugin #841

huseyinbabal opened this issue Nov 8, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@huseyinbabal
Copy link
Contributor

huseyinbabal commented Nov 8, 2022

Overview

Botkube supports kubectl execution and it is a typical Executor plugin. We need to extract it as a standalone plugin.

Acceptance Criteria

  • Extract kubectl executor as a plugin and maintain it Botkube main repository
  • Ensure it is backward compatible.
  • Plugin parameters will be documented in the plugin's README.md page, and they can be provided from Botkube as an environment variable like KUBERNETES_... so that they can be passed to the executable in this line
  • Remember about interactivity
  • Update gRPC executor API
  • Make sure anonymized telemetry is still supported - we can lose some data, but confirm with @brampling if we can do that
  • Update the document

Additional scope / notes

@huseyinbabal huseyinbabal added the enhancement New feature or request label Nov 8, 2022
@huseyinbabal huseyinbabal mentioned this issue Nov 8, 2022
11 tasks
@pkosiec
Copy link
Collaborator

pkosiec commented Nov 23, 2022

See @mszostok's PR: #862

@mszostok mszostok moved this from Blocked to To Review in Botkube Feb 20, 2023
@mszostok mszostok moved this from To Review to Blocked in Botkube Feb 24, 2023
@mszostok
Copy link
Collaborator

mszostok commented Mar 1, 2023

The kubectl plugin was implemented. The only thing that left is to replace it in the e2e tests after adding RBAC support: #1003

@mszostok mszostok closed this as completed Mar 1, 2023
@github-project-automation github-project-automation bot moved this from Blocked to Done in Botkube Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants