Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use filepath.WalkDir instead of filepath.Walk #34250

Open
Gofastasf opened this issue Feb 1, 2025 · 3 comments · May be fixed by #34251
Open

Use filepath.WalkDir instead of filepath.Walk #34250

Gofastasf opened this issue Feb 1, 2025 · 3 comments · May be fixed by #34251
Assignees
@priyanshikhetwani
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.

Comments

@Gofastasf
Copy link

/good-first-issue

What would you like to be added:
filepath.WalkDir where its appropriate.

Why is this needed:
To reduce unnecessary stat call.
@Gofastasf Gofastasf added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 1, 2025
@k8s-ci-robot
Copy link
Contributor

@Gofastasf:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

What would you like to be added:
filepath.WalkDir where its appropriate.

Why is this needed:
To reduce unnecessary stat call.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 1, 2025
@k8s-ci-robot
Copy link
Contributor

There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

  • /sig <group-name>
  • /wg <group-name>
  • /committee <group-name>

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@priyanshikhetwani
Copy link
Contributor

/assign

@priyanshikhetwani priyanshikhetwani linked a pull request Feb 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priyanshikhetwani priyanshikhetwani

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace walk with walkdir priyanshikhetwani/k8s-test-infra
3 participants
@k8s-ci-robot @priyanshikhetwani @Gofastasf