Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags incorrect in conformance test documentation #3500

Closed
taragu opened this issue Dec 30, 2018 · 1 comment
Closed

Flags incorrect in conformance test documentation #3500

taragu opened this issue Dec 30, 2018 · 1 comment
Labels
kind/documentation Categorizes issue or PR as related to documentation.

Comments

@taragu
Copy link

taragu commented Dec 30, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Please provide the following details:

Environment:

Minikube version (use minikube version): v0.30.0

  • OS (e.g. from /etc/os-release): macos
  • VM Driver (e.g. cat ~/.minikube/machines/minikube/config.json | grep DriverName): virtualbox
  • ISO version (e.g. cat ~/.minikube/machines/minikube/config.json | grep -i ISO or minikube ssh cat /etc/VERSION): v0.30.0
  • Install tools:
  • Others:

What happened:
I tried following the documentation to run conformance tests for minikube with the following commands listed in the documentation:
go run hack/e2e.go -v --test --test_args="--ginkgo.focus=\[Conformance\]" --check_version_skew=false --check_node_count=false
and
go run hack/e2e.go -v --test --test_args="--ginkgo.focus=should\supdate\sannotations\son\smodification" --check_version_skew=false --check_node_count=false

However, the flags --check_version_skew and --check_node_count turned out to be invalid flags.

--check_version_skew should be --check-version-skew. I don't know what the correct flag for --check_node_count is.

What you expected to happen:
Running the commands listed in the documentation should be able to launch the conformance tests without the unknown flag error.

How to reproduce it (as minimally and precisely as possible):
Follow the documentation to run the conformance tests.

Output of minikube logs (if applicable):

Anything else do we need to know:

@taragu
Copy link
Author

taragu commented Dec 31, 2018

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

No branches or pull requests

2 participants