Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more description in minikube node add option --worker that adding a control plane feature is not supported #17680

Closed
kimsehwan96 opened this issue Nov 29, 2023 · 1 comment · Fixed by #17909
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@kimsehwan96
Copy link

kimsehwan96 commented Nov 29, 2023

What Happened?

Hello, I tried to add more control plane node in my minikube cluster for testing HA architecture in K8s cluster and control plane and I found that there is minikube node add has option --control-plane and --worker.

There is some description that --control-plane will not work as it describe --control-plane This flag is currently unsupported..

But, --worker option's description is If true, the added node will be marked for work. Defaults to true. (default true) so I thought minikube node add --worker=false would be worked to add control plane node however it wasn't !

So I think add more description in that option will be more helpful such as

--worker If true, the added node will be marked for work. Defaults to true. Even if this flag is set false, control plane will not be added due to add control plane node is not yet supported

AS-IS

--worker If true, the added node will be marked for work. Defaults to true. (default true)

Attach the log file

~ ❯ minikube node add --worker=false
😄  Adding node m02 to cluster minikube
👍  Starting worker node minikube-m02 in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=2200MB) ...

Operating System

macOS (Default)

Driver

QEMU

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
3 participants