# This is a combination of 2 commits.

flyingcircle · flyingcircle · commit f0d21d7c281d · 2019-03-22T08:25:35.000-04:00
# This is the 1st commit message: Issue #3253, improve kubernetes-version error string # This is the commit message #2: Issue #3253, improve kubernetes-version error string
diff --git a/pkg/minikube/bootstrapper/kubeadm/versions.go b/pkg/minikube/bootstrapper/kubeadm/versions.go
@@ -156,7 +156,7 @@ func ParseKubernetesVersion(version string) (semver.Version, error) {
 	// Strip leading 'v' prefix from version for semver parsing
 	v, err := semver.Make(version[1:])
 	if err != nil {
-		return semver.Version{}, errors.Wrap(err, "parsing kubernetes version")
+		return semver.Version{}, errors.Wrap(err, "invalid version, must begin with 'v'")
 	}
 
 	return v, nil

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ func ParseKubernetesVersion(version string) (semver.Version, error) {`
`156`	`156`	`// Strip leading 'v' prefix from version for semver parsing`
`157`	`157`	`v, err := semver.Make(version[1:])`
`158`	`158`	`if err != nil {`
`159`		`- return semver.Version{}, errors.Wrap(err, "parsing kubernetes version")`
	`159`	`+ return semver.Version{}, errors.Wrap(err, "invalid version, must begin with 'v'")`
`160`	`160`	`}`
`161`	`161`
`162`	`162`	`return v, nil`